Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix Issue 3080 #3406

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

try to fix Issue 3080 #3406

wants to merge 4 commits into from

Conversation

CShiru
Copy link

@CShiru CShiru commented May 29, 2020

now the url can contain charater ':'.
relative issue: issue3080

if (relativeUrl.length() > 0) {
if (relativeUrlBuilder.charAt(0) != '/') {
if (!relativeUrl.contains("://")) {
relativeUrlBuilder.insert(0, '/');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alters the URL to be absolute which breaks those whose base URLs have path segments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants